Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 )
Change subject: IMPALA-7501: Slim down partition meta in LocalCatalog mode ...................................................................... Patch Set 3: (7 comments) Thanks Quanlong for this enhancement. Sending some initial comments based on a first pass. http://gerrit.cloudera.org:8080/#/c/17505/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17505/3//COMMIT_MSG@7 PS3, Line 7: meta nit: did you mean metadata ? (meta has other meanings). http://gerrit.cloudera.org:8080/#/c/17505/3//COMMIT_MSG@11 PS3, Line 11: used, nit: use and (remove the comma) http://gerrit.cloudera.org:8080/#/c/17505/3//COMMIT_MSG@11 PS3, Line 11: , mo change to '..suboptimal. Most of them..' http://gerrit.cloudera.org:8080/#/c/17505/3//COMMIT_MSG@27 PS3, Line 27: meta nit: metadata http://gerrit.cloudera.org:8080/#/c/17505/3/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/17505/3/common/thrift/CatalogObjects.thrift@325 PS3, Line 325: // REMOVED: 1: optional byte lineDelim Any reason why these commented fields cannot be removed ? http://gerrit.cloudera.org:8080/#/c/17505/3/common/thrift/CatalogObjects.thrift@332 PS3, Line 332: 27: optional THdfsStorageDescriptor hdfs_storage_descriptor Since this is number 27, could you move it down to line 396 ? The un-ordered numbering makes it confusing to read. http://gerrit.cloudera.org:8080/#/c/17505/3/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/17505/3/common/thrift/CatalogService.thrift@401 PS3, Line 401: 11: optional i64 write_id Does the write_id need to be sent for each partition ? This is the last commit id for the table, so can it be abstracted out and sent outside the partition structure ? It will save 8 bytes per partition but I understand if doing that is not straightforward. -- To view, visit http://gerrit.cloudera.org:8080/17505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I307e7a8193b54a7b3ab93d9ebd194766bbdbd977 Gerrit-Change-Number: 17505 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 28 May 2021 03:47:41 +0000 Gerrit-HasComments: Yes
