Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 )
Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17505/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/17505/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@960 PS4, Line 960: hdfsStorageDescriptor > Yeah, the optimization is borrown from the legacy catalog mode. Ah, I see. Even though it is supported it is not common practice AFAIK. I see a TODO in https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java#L543 to optimize this. Since legacy mode also duplicates this for each partition, I think it is okay to take this up as a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/17505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I307e7a8193b54a7b3ab93d9ebd194766bbdbd977 Gerrit-Change-Number: 17505 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 02 Jun 2021 17:35:10 +0000 Gerrit-HasComments: Yes
