liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17344 )
Change subject: IMPALA-10677: Set selectivity of Not-equal ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/17344/3/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java: http://gerrit.cloudera.org:8080/#/c/17344/3/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@257 PS3, Line 257: distinctValues > I wonder if distinctValues includes the null. If so, we may need to compute If all values of the column are null, the distinctValues is 1; if not, the distinctValues does not includes null http://gerrit.cloudera.org:8080/#/c/17344/3/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java File fe/src/test/java/org/apache/impala/planner/CardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/17344/3/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@70 PS3, Line 70: verifyCardinality( : "SELECT id FROM functional.alltypes WHE > Should we remove this comment, since the calculation is correct with the pa Done http://gerrit.cloudera.org:8080/#/c/17344/3/testdata/workloads/functional-planner/queries/PlannerTest/card-scan.test File testdata/workloads/functional-planner/queries/PlannerTest/card-scan.test: http://gerrit.cloudera.org:8080/#/c/17344/3/testdata/workloads/functional-planner/queries/PlannerTest/card-scan.test@160 PS3, Line 160: from functional.alltypestiny > Remove? Done -- To view, visit http://gerrit.cloudera.org:8080/17344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd6f5945840ea2a8194d72aa440ddfa6915cbb3a Gerrit-Change-Number: 17344 Gerrit-PatchSet: 4 Gerrit-Owner: liuyao <liu...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: liuyao <liu...@sensorsdata.cn> Gerrit-Comment-Date: Fri, 04 Jun 2021 03:37:28 +0000 Gerrit-HasComments: Yes
