Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17344 )
Change subject: IMPALA-10677: Set selectivity of Not-equal ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Thanks again for the verification. Looks good! http://gerrit.cloudera.org:8080/#/c/17344/3/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java: http://gerrit.cloudera.org:8080/#/c/17344/3/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@257 PS3, Line 257: distinctValues > If the column contains null, but not all null, then distinctValues does not Okay. Thanks for the verification. We could make an adjustment here if there is a way to detect this situation. But it looks like Expr does not tell us # of nulls in general. Done. -- To view, visit http://gerrit.cloudera.org:8080/17344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd6f5945840ea2a8194d72aa440ddfa6915cbb3a Gerrit-Change-Number: 17344 Gerrit-PatchSet: 4 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: liuyao <[email protected]> Gerrit-Comment-Date: Fri, 04 Jun 2021 13:13:19 +0000 Gerrit-HasComments: Yes
