Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17550 )
Change subject: IMPALA-10728: Check access privileges inside masking expressions ...................................................................... Patch Set 3: (2 comments) Thank Csaba's quick review! http://gerrit.cloudera.org:8080/#/c/17550/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17550/2//COMMIT_MSG@31 PS2, Line 31: appli > nit: applied Done http://gerrit.cloudera.org:8080/#/c/17550/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/17550/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3260 PS2, Line 3260: .error(selectError("functional.alltypes"), : onColumn("functional", "alltypes", "id", TPrivilegeLevel.SELECT)) > Can you add a check where we have privilege only for int_col? Good point! Done. -- To view, visit http://gerrit.cloudera.org:8080/17550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I772fa2f5d189b1272e8419ed1fb5b34d373d3601 Gerrit-Change-Number: 17550 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 07 Jun 2021 14:58:05 +0000 Gerrit-HasComments: Yes
