Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17550 )
Change subject: IMPALA-10728: Check access privileges inside masking expressions ...................................................................... Patch Set 3: Code-Review+1 (1 comment) lgtm. A minor comment below. http://gerrit.cloudera.org:8080/#/c/17550/3/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/17550/3/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@571 PS3, Line 571: // We restore the privileges collected in the first pass below. So, no point in nit: this comment should. be updated since the for loop for restore privilege has been moved up. -- To view, visit http://gerrit.cloudera.org:8080/17550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I772fa2f5d189b1272e8419ed1fb5b34d373d3601 Gerrit-Change-Number: 17550 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 08 Jun 2021 01:15:10 +0000 Gerrit-HasComments: Yes
