Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17560 )
Change subject: IMPALA-10735: Fix Iceberg insert when event polling is enabled ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17560/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17560/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5021 PS1, Line 5021: if (!catalog_.isEventProcessingActive()) return false; Since you are modified this code anyways, I was thinking we should remove this. Generating insert events should not be conditional to events processor being active or not. http://gerrit.cloudera.org:8080/#/c/17560/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5023 PS1, Line 5023: FeIcebergTable I wonder why do we not hit this exception for Hbase or KuduTable. It probably makes sense if we change this condition as: if (table instanceof HdfsTable) return true; return false; -- To view, visit http://gerrit.cloudera.org:8080/17560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4c3d7d4c0edf0d45628cf6d44785bad1049d76 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 08 Jun 2021 18:26:26 +0000 Gerrit-HasComments: Yes
