Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17560 )
Change subject: IMPALA-10735: Fix Iceberg insert when event polling is enabled ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17560/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17560/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5021 PS2, Line 5021: if (table instanceof FeIcebergTable) return false; : if (!BackendConfig.INSTANCE.isInsertEventsEnabled()) return false; : return true; > Seems to me the test on iceberg tables can be done first, regardless of the Vihang asked me to remove catalog_.isEventProcessingActive(). I switched the order. -- To view, visit http://gerrit.cloudera.org:8080/17560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4c3d7d4c0edf0d45628cf6d44785bad1049d76 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 09 Jun 2021 14:10:30 +0000 Gerrit-HasComments: Yes
