Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 )
Change subject: IMPALA-10720: Add versioning to admission heartbeats ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/17524/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17524/1//COMMIT_MSG@10 PS1, Line 10: allows the admission service to ignore stale (out of order) > Maybe clarify that stale here means out of order? Done http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.h File be/src/scheduling/admission-control-service.h: http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.h@138 PS1, Line 138: /// Maps from coordinator ID to the latest heartbeat version number that was processed > Nit: "coordinator" Done http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.h@140 PS1, Line 140: /// TODO: Leverage IMPALA-9155 to add coord_id the first time a coord sends a heartbeat > I think this map will contains stale data form coordinators that have resta Added a TODO to add a mechanism to delete ids when coords fail http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.cc@276 PS1, Line 276: VLOG(1) << "Stale heartbeat received for coord_id: "<< req->host_id(); > Maybe should also say that this may be expected if a coordinator restarts. if a coord restarts it'll receive a new Id when it registers with the statestore. So this case can only happen due to network issues. -- To view, visit http://gerrit.cloudera.org:8080/17524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1338211dc0bca67f8fde93a1b05c0780be583d5d Gerrit-Change-Number: 17524 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 21 Jun 2021 22:18:18 +0000 Gerrit-HasComments: Yes
