Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 )
Change subject: IMPALA-10720: Add versioning to admission heartbeats ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17524/2/be/src/scheduling/admission-control-service.h File be/src/scheduling/admission-control-service.h: http://gerrit.cloudera.org:8080/#/c/17524/2/be/src/scheduling/admission-control-service.h@139 PS2, Line 139: /// from it. NOTE: Can contain stale data from coordinators that have restarted. > Nit: "from" Done http://gerrit.cloudera.org:8080/#/c/17524/2/common/protobuf/admission_control_service.proto File common/protobuf/admission_control_service.proto: http://gerrit.cloudera.org:8080/#/c/17524/2/common/protobuf/admission_control_service.proto@274 PS2, Line 274: /// resources. Stale heartbeat messages are ignored. > Nit: "heartbeat" Done -- To view, visit http://gerrit.cloudera.org:8080/17524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1338211dc0bca67f8fde93a1b05c0780be583d5d Gerrit-Change-Number: 17524 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Aug 2021 00:59:02 +0000 Gerrit-HasComments: Yes