Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17615 )
Change subject: IMPALA-10755: Fix migration of analytic predicate to inline view. ...................................................................... Patch Set 2: Code-Review+2 (2 comments) LGTM. Bump to +2 since the GVO passed. Thanks for fixing this quickly! http://gerrit.cloudera.org:8080/#/c/17615/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/17615/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1408 PS1, Line 1408: } > I did not change this because after looking at the implementation of SlotRe I see. Thanks for the explanation! http://gerrit.cloudera.org:8080/#/c/17615/2/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/17615/2/tests/query_test/test_queries.py@367 PS2, Line 367: class TestAnalyticFnsTpch(ImpalaTestSuite): > flake8: E302 expected 2 blank lines, found 1 nit: we need one more blank line above. -- To view, visit http://gerrit.cloudera.org:8080/17615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5cad3d408ee3695cafb35f66a4f19b4e8d0529e Gerrit-Change-Number: 17615 Gerrit-PatchSet: 2 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 24 Jun 2021 00:38:33 +0000 Gerrit-HasComments: Yes
