Aman Sinha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17615 )

Change subject: IMPALA-10755: Fix migration of analytic predicate to inline 
view.
......................................................................


Patch Set 3: Verified+1 Code-Review+2

(1 comment)

Carry +2 from Quanlong.
Adding +1 for Verified based on successful GVO run.

http://gerrit.cloudera.org:8080/#/c/17615/2/tests/query_test/test_queries.py
File tests/query_test/test_queries.py:

http://gerrit.cloudera.org:8080/#/c/17615/2/tests/query_test/test_queries.py@367
PS2, Line 367:
> nit: we need one more blank line above.
Done



--
To view, visit http://gerrit.cloudera.org:8080/17615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cad3d408ee3695cafb35f66a4f19b4e8d0529e
Gerrit-Change-Number: 17615
Gerrit-PatchSet: 3
Gerrit-Owner: Aman Sinha <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 24 Jun 2021 01:31:30 +0000
Gerrit-HasComments: Yes

Reply via email to