Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 )
Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.cc@579 PS5, Line 579: Status hash_allocation_status = allocator_->Allocate(new_hash_size, &new_hash_allocation); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.inline.h File be/src/exec/hash-table.inline.h: http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.inline.h@70 PS5, Line 70: && ht_ctx->Equals<INCLUSIVE_EQUALITY>(GetRow(bucket, ht_ctx->scratch_row_, bd))) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.inline.h@103 PS5, Line 103: int64_t bucket_idx = Probe<true, true>(buckets_, num_buckets_, ht_ctx, hash, &found, &bd); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.inline.h@155 PS5, Line 155: int64_t bucket_idx = Probe<false, true>(buckets_, num_buckets_, ht_ctx, hash, &found, &bd); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.inline.h@168 PS5, Line 168: int64_t bucket_idx = Probe<true, true>(buckets_, num_buckets_, ht_ctx, hash, found, &bd); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72912ae9353b0d567a976ca712d2d193e035df9b Gerrit-Change-Number: 17592 Gerrit-PatchSet: 5 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 04 Jul 2021 16:44:58 +0000 Gerrit-HasComments: Yes
