Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 )
Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. ...................................................................... Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/17592/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17592/5//COMMIT_MSG@9 PS5, Line 9: contiguou > contiguous? Done http://gerrit.cloudera.org:8080/#/c/17592/5//COMMIT_MSG@61 PS5, Line 61: of the > duplicated 'the' Done http://gerrit.cloudera.org:8080/#/c/17592/5//COMMIT_MSG@69 PS5, Line 69: of thi > of this Done http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.h@653 PS5, Line 653: IsMatched( > The namings are inconsistent a bit in this file. Some functions use undersc Done. Changed all the names. http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.h@674 PS5, Line 674: td > nit: probably name it 'tdn' to be more clear? Done http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/exec/hash-table.h@711 PS5, Line 711: GetBu > nit: we usually don't abbreviate, i.e. it should be 'getBucketData()' Done http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/util/tagged-ptr.h File be/src/util/tagged-ptr.h: http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/util/tagged-ptr.h@66 PS5, Line 66: S > nit: 'S', i.e. we are using UpperCamelCase for functions. Done. Changed it throughout the file. http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/util/tagged-ptr.h@103 PS5, Line 103: data > nit: data_, i.e. we postfix member variables with '_' Done -- To view, visit http://gerrit.cloudera.org:8080/17592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72912ae9353b0d567a976ca712d2d193e035df9b Gerrit-Change-Number: 17592 Gerrit-PatchSet: 6 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Jul 2021 11:18:05 +0000 Gerrit-HasComments: Yes
