Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17568 )
Change subject: IMPALA-10738: Min/max filters should be enabled for partition columns ...................................................................... Patch Set 14: (1 comment) I took an initial look. The change looks good to me. Is it possible to make it work for Iceberg partitions? You can see an example of how to check if a column is used in the Iceberg partition spec: https://github.com/apache/impala/blob/fcaea30b151d89f412816a8e49d5feeef6964a0f/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java#L966-L969 If that gets too complicated we can create a separate Jira for it. http://gerrit.cloudera.org:8080/#/c/17568/14/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/17568/14/be/src/service/query-options.cc@1093 PS14, Line 1093: nit: space -- To view, visit http://gerrit.cloudera.org:8080/17568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e135ef48b4bb36d70075287b03d1c12496b042 Gerrit-Change-Number: 17568 Gerrit-PatchSet: 14 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Jul 2021 16:29:04 +0000 Gerrit-HasComments: Yes
