Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17568 )
Change subject: IMPALA-10738: Min/max filters should be enabled for partition columns ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/17568/14/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/17568/14/be/src/service/query-options.cc@1093 PS14, Line 1093: > Done Seems like you haven't uploaded the new PS. http://gerrit.cloudera.org:8080/#/c/17568/14/testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test File testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test: http://gerrit.cloudera.org:8080/#/c/17568/14/testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test@9 PS14, Line 9: F00:PLAN FRAGMENT [UNPARTITIONED] hosts=1 instances=1 : | Per-Host Resources: mem-estimate=34.94MB mem-reservation=5.00MB thread-reservation=3 runtime-filters-memory=1.00MB : PLAN-ROOT SINK : | output exprs: count(*) : | mem-estimate=4.00MB mem-reservation=4.00MB spill-buffer=2.00MB thread-reservation=0 : | : 03:AGGREGATE [FINALIZE] : | output: count(*) : | mem-estimate=16.00KB mem-reservation=0B spill-buffer=2.00MB thread-reservation=0 : | tuple-ids=2 row-size=8B cardinality=1 : | in pipelines: 03(GETNEXT), 00(OPEN) : | : 02:HASH JOIN [INNER JOIN] : | hash predicates: a.id = b.id : | fk/pk conjuncts: assumed fk/pk : | runtime filters: RF000[bloom] <- b.id : | mem-estimate=1.94MB mem-reservation=1.94MB spill-buffer=64.00KB thread-reservation=0 : | tuple-ids=0,1 row-size=8B cardinality=12.82K : | in pipelines: 00(GETNEXT), 01(OPEN) : | : |--01:SCAN HDFS [functional_parquet.alltypes b] : | HDFS partitions=24/24 files=24 size=201.59KB : | stored statistics: : | table: rows=unavailable size=unavailable : | partitions: 0/24 rows=12.82K : | columns: unavailable : | extrapolated-rows=disabled max-scan-range-rows=unavailable : | mem-estimate=16.00MB mem-reservation=16.00KB thread-reservation=1 : | tuple-ids=1 row-size=4B cardinality=12.82K : | in pipelines: 01(GETNEXT) : | : 00:SCAN HDFS [functional_parquet.alltypes a] : HDFS partitions=24/24 files=24 size=201.59KB : runtime filters: RF000[bloom] -> a.id : stored statistics: : table: rows=unavailable size=unavailable : partitions: 0/24 rows=12.82K : columns: unavailable : extrapolated-rows=disabled max-scan-range-rows=unavailable : mem-estimate=16.00MB mem-reservation=16.00KB thread-reservation=1 : tuple-ids=0 row-size=4B cardinality=12.82K : in pipelines: 00(GETNEXT) Why did the numbers change here while there is no new filter in the plan? http://gerrit.cloudera.org:8080/#/c/17568/14/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters-hdfs-num-rows-est-enabled.test File testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters-hdfs-num-rows-est-enabled.test: http://gerrit.cloudera.org:8080/#/c/17568/14/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters-hdfs-num-rows-est-enabled.test@a25 PS14, Line 25: Why the bloom filters don't get generated in the new plans? -- To view, visit http://gerrit.cloudera.org:8080/17568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e135ef48b4bb36d70075287b03d1c12496b042 Gerrit-Change-Number: 17568 Gerrit-PatchSet: 14 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Jul 2021 10:11:01 +0000 Gerrit-HasComments: Yes
