Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17308 )

Change subject: IMPALA-10502: Handle CREATE/DROP events correctly
......................................................................


Patch Set 16:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/17308/16/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java:

http://gerrit.cloudera.org:8080/#/c/17308/16/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@709
PS16, Line 709:         partitionStats, hasIncrementalStats, numRows, writeId, 
inFlightEvents, /*createEventId=*/-1L);
line too long (102 > 90)


http://gerrit.cloudera.org:8080/#/c/17308/16/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/17308/16/tests/custom_cluster/test_event_processing.py@362
PS16, Line 362: >>>>>>> 412cbbf4c9... IMPALA-10502: Handle CREATE/DROP events 
correctly
flake8: E305 expected 2 blank lines after class or function definition, found 1


http://gerrit.cloudera.org:8080/#/c/17308/16/tests/custom_cluster/test_event_processing.py@362
PS16, Line 362: >
flake8: E999 SyntaxError: invalid syntax


http://gerrit.cloudera.org:8080/#/c/17308/16/tests/custom_cluster/test_event_processing.py@362
PS16, Line 362: >
flake8: E225 missing whitespace around operator


http://gerrit.cloudera.org:8080/#/c/17308/16/tests/custom_cluster/test_event_processing.py@362
PS16, Line 362: -
flake8: E226 missing whitespace around arithmetic operator


http://gerrit.cloudera.org:8080/#/c/17308/16/tests/custom_cluster/test_event_processing.py@362
PS16, Line 362: /
flake8: E226 missing whitespace around arithmetic operator



--
To view, visit http://gerrit.cloudera.org:8080/17308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c5e96b48abac015240f20295b3ec3b1d71f24a
Gerrit-Change-Number: 17308
Gerrit-PatchSet: 16
Gerrit-Owner: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 06 Jul 2021 22:58:52 +0000
Gerrit-HasComments: Yes

Reply via email to