Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17308 )
Change subject: IMPALA-10502: Handle CREATE/DROP events correctly ...................................................................... Patch Set 18: Code-Review+2 (4 comments) Thanks for working on this. The change looks great! http://gerrit.cloudera.org:8080/#/c/17308/15/fe/src/main/java/org/apache/impala/catalog/events/DeleteEventLog.java File fe/src/main/java/org/apache/impala/catalog/events/DeleteEventLog.java: http://gerrit.cloudera.org:8080/#/c/17308/15/fe/src/main/java/org/apache/impala/catalog/events/DeleteEventLog.java@41 PS15, Line 41: SortedMap > The events come in sorted order so we can use LinkedList. However, using Tr I see, OK. http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py File tests/custom_cluster/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py@127 PS18, Line 127: nit: indent should be +4 http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py@167 PS18, Line 167: nit: should be +4 indent http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py@310 PS18, Line 310: nit: should be +4 indent -- To view, visit http://gerrit.cloudera.org:8080/17308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c5e96b48abac015240f20295b3ec3b1d71f24a Gerrit-Change-Number: 17308 Gerrit-PatchSet: 18 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Jul 2021 13:05:10 +0000 Gerrit-HasComments: Yes
