Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17610 )
Change subject: IMPALA-9338 Fix impala crashing in impala::RowDescriptor::TupleIsNullable(int) ...................................................................... Patch Set 2: (2 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/17610/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/17610/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1011 PS2, Line 1011: int bestConjunctIdx = 0; May add a comment here to indicate that 'bestConjunctIdx' uniquely identifies the best conjunct in 'remaining' list even in the case of ties, and possibly the JIRA IMPALA-9338. http://gerrit.cloudera.org:8080/#/c/17610/2/testdata/workloads/tpch/queries/tpch-outer-joins.test File testdata/workloads/tpch/queries/tpch-outer-joins.test: http://gerrit.cloudera.org:8080/#/c/17610/2/testdata/workloads/tpch/queries/tpch-outer-joins.test@62 PS2, Line 62: Can we add several new test cases which exercise the combination of regular and delimited column identifiers? For example, a small test table T with 4 columns: col1, col2, `Col1`, and `col2` and some data. And a couple test queries 1. select * from t a, t b where a.col1 = b.col2 and a.`Col1` = b.`Col2` 2. select * from t a, t b where a.col1 = b.`Col2` and a.`Col1` = b.Col2 -- To view, visit http://gerrit.cloudera.org:8080/17610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba031d7a6eda21a77b0e53bc41772ee9e00a528 Gerrit-Change-Number: 17610 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 09 Jul 2021 14:27:34 +0000 Gerrit-HasComments: Yes
