Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17610 )
Change subject: IMPALA-9338 Fix impala crashing in impala::RowDescriptor::TupleIsNullable(int) ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17610/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/17610/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1011 PS2, Line 1011: int bestConjunctIdx = 0; > May add a comment here to indicate that 'bestConjunctIdx' uniquely identifi Done http://gerrit.cloudera.org:8080/#/c/17610/2/testdata/workloads/tpch/queries/tpch-outer-joins.test File testdata/workloads/tpch/queries/tpch-outer-joins.test: http://gerrit.cloudera.org:8080/#/c/17610/2/testdata/workloads/tpch/queries/tpch-outer-joins.test@62 PS2, Line 62: > Can we add several new test cases which exercise the combination of regular Since we don't distinct delimited columns with different letter cases now(`Col1` and `col1` are treated as the same), added a special testcase using reserved word. -- To view, visit http://gerrit.cloudera.org:8080/17610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba031d7a6eda21a77b0e53bc41772ee9e00a528 Gerrit-Change-Number: 17610 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 16 Jul 2021 12:45:43 +0000 Gerrit-HasComments: Yes
