Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17635 )
Change subject: IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns ...................................................................... Patch Set 8: Code-Review+2 (1 comment) LGTM http://gerrit.cloudera.org:8080/#/c/17635/8/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test: http://gerrit.cloudera.org:8080/#/c/17635/8/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test@284 PS8, Line 284: PRIMARY KEY (ss_item_sk, ss_ticket_number) nit: PRIMARY KEY seems useless here. I think it's only used by Kudu tables. -- To view, visit http://gerrit.cloudera.org:8080/17635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a528ffbd0e333721ef38b4be7d4ddcdbf188adf Gerrit-Change-Number: 17635 Gerrit-PatchSet: 8 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 11 Jul 2021 13:40:11 +0000 Gerrit-HasComments: Yes
