Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17635 )
Change subject: IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns ...................................................................... Patch Set 8: Code-Review+2 (4 comments) Found few nits, but LGTM! http://gerrit.cloudera.org:8080/#/c/17635/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17635/8//COMMIT_MSG@13 PS8, Line 13: valuess values http://gerrit.cloudera.org:8080/#/c/17635/8//COMMIT_MSG@15 PS8, Line 15: valuess values http://gerrit.cloudera.org:8080/#/c/17635/8/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/17635/8/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@304 PS8, Line 304: -1 Do we need to set the limit parameter for split()? http://gerrit.cloudera.org:8080/#/c/17635/8/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/17635/8/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@729 PS8, Line 729: allowRuntimeFilter nit: Since this mmethod is only about Min/Max filters, and not bloom filters, probably we should rename it to allowMinMaxFilter() -- To view, visit http://gerrit.cloudera.org:8080/17635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a528ffbd0e333721ef38b4be7d4ddcdbf188adf Gerrit-Change-Number: 17635 Gerrit-PatchSet: 8 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 12 Jul 2021 12:17:23 +0000 Gerrit-HasComments: Yes
