Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17466 )
Change subject: IMPALA-10626: Add support for Iceberg's Catalogs API ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/17466/5/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/17466/5/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@680 PS5, Line 680: putGeneratedKuduProperty > This name could be changed as we are using this function for non Kudu stuff Renamed it to putGeneratedProperty(). http://gerrit.cloudera.org:8080/#/c/17466/4/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java: http://gerrit.cloudera.org:8080/#/c/17466/4/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@70 PS4, Line 70: .ICE Use CatalogUtil.ICEBERG_CATALOG_TYPE_HIVE http://gerrit.cloudera.org:8080/#/c/17466/5/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java: http://gerrit.cloudera.org:8080/#/c/17466/5/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@72 PS5, Line 72: equals > Maybe it would be safer to use case insensitive comparison. Done http://gerrit.cloudera.org:8080/#/c/17466/5/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@163 PS5, Line 163: JNDI uses the context class loader > It would be nice to create an Iceberg issue for this, as other users of the I think it's only an issue for native projects. JVM-based clients will not hit this because the context class loader will be set and it will be able to load the needed classes. I'm a bit skeptic that the Iceberg project will do such an invasive change when the workaround is fairly simple. -- To view, visit http://gerrit.cloudera.org:8080/17466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5dfa150986117fc55b28034c4eda38a736460ead Gerrit-Change-Number: 17466 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 14 Jul 2021 14:15:49 +0000 Gerrit-HasComments: Yes
