Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17466 )
Change subject: IMPALA-10626: Add support for Iceberg's Catalogs API ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17466/5/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java: http://gerrit.cloudera.org:8080/#/c/17466/5/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@163 PS5, Line 163: JNDI uses the context class loader > I think it's only an issue for native projects. JVM-based clients will not Ok, I am not the familiar about the best practices in Java. -- To view, visit http://gerrit.cloudera.org:8080/17466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5dfa150986117fc55b28034c4eda38a736460ead Gerrit-Change-Number: 17466 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 15 Jul 2021 10:14:31 +0000 Gerrit-HasComments: Yes
