Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17705 )
Change subject: IMPALA-10813: Invalidate external table from catalog cache for truncate table HMS api ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patch looks good to me. Can you please fix the code style issues. http://gerrit.cloudera.org:8080/#/c/17705/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17705/1//COMMIT_MSG@9 PS1, Line 9: This patch is in continuation of IMPALA-10648 in which we missed invalidating external : table for truncate_table api nit, can you please reformat the commit message to a line-width of 72 chars? Copying this from https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala in case you are not familiar. "Finally, please write a good, clear commit message, with a short, descriptive title and a message that is exactly long enough to explain what the problem was, and how it was fixed. Each should have 72 or fewer characters if possible. The first line should have an empty line after it, and the first line should begin with the ticket(s) addressed, followed by a colon and a space:" http://gerrit.cloudera.org:8080/#/c/17705/1/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/17705/1/tests/custom_cluster/test_metastore_service.py@24 PS1, Line 24: from hive_metastore.ttypes import GetValidWriteIdsRequest > flake8: F401 'hive_metastore.ttypes.GetValidWriteIdsRequest' imported but u Can you please remove this if not needed? -- To view, visit http://gerrit.cloudera.org:8080/17705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734c2b5f371291fef32badab9efc886b4b067e10 Gerrit-Change-Number: 17705 Gerrit-PatchSet: 1 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Wed, 21 Jul 2021 17:55:52 +0000 Gerrit-HasComments: Yes
