Sourabh Goyal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17705 )

Change subject: IMPALA-10813: Invalidate external table from catalog cache for 
truncate table HMS api
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17705/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17705/1//COMMIT_MSG@9
PS1, Line 9: This patch is in continuation of IMPALA-10648 in which we missed 
invalidating external
           : table for truncate_table api
> nit, can you please reformat the commit message to a line-width of 72 chars
Sure.


http://gerrit.cloudera.org:8080/#/c/17705/1/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:

http://gerrit.cloudera.org:8080/#/c/17705/1/tests/custom_cluster/test_metastore_service.py@24
PS1, Line 24: from hive_metastore.ttypes import GetValidWriteIdsRequest
> Can you please remove this if not needed?
Ack



--
To view, visit http://gerrit.cloudera.org:8080/17705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I734c2b5f371291fef32badab9efc886b4b067e10
Gerrit-Change-Number: 17705
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Yu-Wen Lai <[email protected]>
Gerrit-Comment-Date: Thu, 22 Jul 2021 12:20:17 +0000
Gerrit-HasComments: Yes

Reply via email to