Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17638 )
Change subject: WiP: IMPALA-9495: Support struct in select list for ORC tables ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/17638/3/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java: http://gerrit.cloudera.org:8080/#/c/17638/3/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java@239 PS3, Line 239: if (parentStructSlot_ != null) toStrHelper.add("parentSlot", parentStructSlot_.getId()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17638/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/17638/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1018 PS3, Line 1018: "Incompatible return types 'STRUCT<b:BOOLEAN>' and 'STRUCT<b:BOOLEAN>' of exprs " + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17638/3/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/17638/3/tests/query_test/test_nested_types.py@115 PS3, Line 115: class TestNestedTypesInSelectList(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/17638/3/tests/query_test/test_nested_types.py@130 PS3, Line 130: flake8: E203 whitespace before ':' -- To view, visit http://gerrit.cloudera.org:8080/17638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fbe56bdcd372b72e99c0195d87a818e7fa4bc3a Gerrit-Change-Number: 17638 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 26 Jul 2021 07:55:16 +0000 Gerrit-HasComments: Yes
