Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17638 )
Change subject: WiP: IMPALA-9495: Support struct in select list for ORC tables ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17638/4/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: http://gerrit.cloudera.org:8080/#/c/17638/4/be/src/runtime/tuple.cc@237 PS4, Line 237: RawValue::Write(src, this, slot_desc, pool, &string_values); Might want to push 'COLLECT_STRING_VALS' into RawValue::Write() to prevent spending time on gathering the struct vals if they won't be used at the callsite. Taking into account that this is executed in the critical path (for each row) this might make a difference in performance. -- To view, visit http://gerrit.cloudera.org:8080/17638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fbe56bdcd372b72e99c0195d87a818e7fa4bc3a Gerrit-Change-Number: 17638 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Wed, 04 Aug 2021 13:04:18 +0000 Gerrit-HasComments: Yes
