Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17729 )
Change subject: IMPALA-10825: fix impalad crashes when closing the retrying query ...................................................................... Patch Set 2: (3 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/17729/2/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/17729/2/tests/custom_cluster/test_query_retries.py@760 PS2, Line 760: select count(*) from tpch_parquet.lineitem nit. Test robustness. Wonder if this query should be relatively complex (such as a self join of store_sales table) so that its execution time is long enough (say 10s) to allow the close_query() action below to succeed always. http://gerrit.cloudera.org:8080/#/c/17729/2/tests/custom_cluster/test_query_retries.py@764 PS2, Line 764: time.sleep(1) : self.client.close_query(handle) nit. May add a comment "close the query" here. http://gerrit.cloudera.org:8080/#/c/17729/2/tests/custom_cluster/test_query_retries.py@773 PS2, Line 773: first_impalad() nit. should we check all remaining impalads are running instead of the 1st one only? -- To view, visit http://gerrit.cloudera.org:8080/17729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b9a2cccbfbdca00b099e0f8d5f2d4bcb4d0a8c3 Gerrit-Change-Number: 17729 Gerrit-PatchSet: 2 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 27 Jul 2021 13:30:02 +0000 Gerrit-HasComments: Yes
