Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17729 )
Change subject: IMPALA-10825: fix impalad crashes when closing the retrying query ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Looks great! http://gerrit.cloudera.org:8080/#/c/17729/2/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/17729/2/tests/custom_cluster/test_query_retries.py@760 PS2, Line 760: select count(*) from tpch_parquet.lineitem > Not need. We use the debug action to delay and have enough time to do close Done http://gerrit.cloudera.org:8080/#/c/17729/2/tests/custom_cluster/test_query_retries.py@773 PS2, Line 773: > This bug only crashes the coordinator, so check the first one is enough Done -- To view, visit http://gerrit.cloudera.org:8080/17729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b9a2cccbfbdca00b099e0f8d5f2d4bcb4d0a8c3 Gerrit-Change-Number: 17729 Gerrit-PatchSet: 4 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Wed, 28 Jul 2021 13:17:24 +0000 Gerrit-HasComments: Yes
