Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17741 )
Change subject: [WIP]: Add drop event id to deleteEventLog for drop db/table/partition events ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17741/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17741/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@709 PS4, Line 709: addToDeleteEventLog If the goal is to make sure that drops from the metastore service handler are added to the deleteEventLog then this should be done at a higher level from like from removeNonTransactionalTableIfExists() method because this method is executed by events processor's drop table event as well. http://gerrit.cloudera.org:8080/#/c/17741/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@873 PS4, Line 873: addToDeleteEventLog I don't understand this change. Perhaps you can explain me this better. This method is called from MetastoreEventsProcessor when it processes the DROP_DATABASE event. Why do we need to add it to deleteEventLog for this? The main idea of deleteEventLog is to detect self-events for drop events. The DDL execution logic will add to the delete event log and events processor will remove it when it received that event. But here I see that we are adding it from events processor? How do we even use this delete event added to the log since we are never going to receive the same event again. -- To view, visit http://gerrit.cloudera.org:8080/17741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffa519a477e211891e7fa7118950628ec42b45d4 Gerrit-Change-Number: 17741 Gerrit-PatchSet: 4 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 30 Jul 2021 18:21:57 +0000 Gerrit-HasComments: Yes
