Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17741 )
Change subject: [WIP]: Add drop event id to deleteEventLog for drop db/table/partition events ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/17741/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17741/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@873 PS4, Line 873: addToDeleteEventLog > Thanks for the explanation. The approach only slightly simplifies the DDL c Sure @Vihang. I agree that there is a better way to handle adding event ids to deleteEventLog for Impala shell and Metastore server. I will abandon this patch. Thank you for sharing your feedback ! -- To view, visit http://gerrit.cloudera.org:8080/17741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffa519a477e211891e7fa7118950628ec42b45d4 Gerrit-Change-Number: 17741 Gerrit-PatchSet: 4 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 03 Aug 2021 10:17:29 +0000 Gerrit-HasComments: Yes
