[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17727 )
Change subject: IMPALA-10797: Frontend changes to enable 'stored as JSONFILE' ...................................................................... Patch Set 5: (4 comments) > (2 comments) http://gerrit.cloudera.org:8080/#/c/17727/4/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java File fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java: http://gerrit.cloudera.org:8080/#/c/17727/4/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java@152 PS4, Line 152: Returns the file format associated with the input format class, or null if : * the input format class is not supported. > I only find two usages of this in AlterTableSetRowFormatStmt#analyze(): htt Done http://gerrit.cloudera.org:8080/#/c/17727/4/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java@161 PS4, Line 161: return HdfsFileFormat.JSON; : } > We should use String#equals() instead of "==" here. You can add a constant, Done http://gerrit.cloudera.org:8080/#/c/17727/4/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java@163 PS4, Line 163: } > Could you add a Precondition check above this to make sure input format is Done http://gerrit.cloudera.org:8080/#/c/17727/4/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java@183 PS4, Line 183: public static HdfsFileFormat fromThrift(THdfsFileFormat thriftFormat) { > same comment as above Done -- To view, visit http://gerrit.cloudera.org:8080/17727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b8cb2f59df3af09902b49d3bdac16c19954b305 Gerrit-Change-Number: 17727 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 10 Aug 2021 16:17:31 +0000 Gerrit-HasComments: Yes
