Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17727 )
Change subject: IMPALA-10797: Frontend changes to enable 'stored as JSONFILE' ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/17727/7/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java File fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java: http://gerrit.cloudera.org:8080/#/c/17727/7/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@238 PS7, Line 238: blockSize nit: keep this unrelative code unchange http://gerrit.cloudera.org:8080/#/c/17727/5/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test File testdata/workloads/functional-query/queries/QueryTest/show-create-table.test: http://gerrit.cloudera.org:8080/#/c/17727/5/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test@25 PS5, Line 25: id INT > Added ORC,AVRO,KUDU. PARQUET, SEQUENCEFILE, TEXT, ICEBERG already have test Oh sorry, I mean data types, e.g. BIGINT, STRING, TIMESTAMP, etc. We don't need to add tests for other file formats. -- To view, visit http://gerrit.cloudera.org:8080/17727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b8cb2f59df3af09902b49d3bdac16c19954b305 Gerrit-Change-Number: 17727 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 00:06:04 +0000 Gerrit-HasComments: Yes
