Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17760 )
Change subject: IMPALA-10858: HMS request for acid fds fixed. ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/17760/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java: http://gerrit.cloudera.org:8080/#/c/17760/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@188 PS2, Line 188: for (THdfsFileDesc fd : response.table_info.partitions.get(0).insert_file_descriptors) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17760/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@191 PS2, Line 191: for (THdfsFileDesc fd : response.table_info.partitions.get(0).delete_file_descriptors) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17760/2/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java: http://gerrit.cloudera.org:8080/#/c/17760/2/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java@110 PS2, Line 110: ValidWriteIdList writeIdList = getValidWriteIdList("function_orc_def", "alltypes_deleted_rows"); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17760/2/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java@112 PS2, Line 112: .getOrLoadTable("functional_orc_def", "alltypes_deleted_rows", "test", writeIdList); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055960bf0471d62bc37dda3403f58f86f9b5f596 Gerrit-Change-Number: 17760 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 13 Aug 2021 03:16:21 +0000 Gerrit-HasComments: Yes
