Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17760 )
Change subject: IMPALA-10858: HMS request for acid fds fixed. ...................................................................... Patch Set 4: (3 comments) The patch looks good to me. I have some minor suggestions/questions below. Once you address them I can +2 this change. http://gerrit.cloudera.org:8080/#/c/17760/4/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java: http://gerrit.cloudera.org:8080/#/c/17760/4/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@442 PS4, Line 442: isSetGetFileMetadata Why do we need this? I thought we had intentionally changed it earlier from isSetGetFileMetadata in https://gerrit.cloudera.org/#/c/17330 (which was later included in https://gerrit.cloudera.org/#/c/17429/ http://gerrit.cloudera.org:8080/#/c/17760/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/17760/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1631 PS4, Line 1631: public static Can you please add a comment to these methods saying that they are made visible intentionally. This will hopefully avoid situations where someone unintentionally reduces the visibility of these methods. http://gerrit.cloudera.org:8080/#/c/17760/4/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java: http://gerrit.cloudera.org:8080/#/c/17760/4/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java@108 PS4, Line 108: testFileMetadataForAcidPartitions nit, It would be great if we could add coverage for non-partitioned ACID tables as well for getTableReq API. -- To view, visit http://gerrit.cloudera.org:8080/17760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055960bf0471d62bc37dda3403f58f86f9b5f596 Gerrit-Change-Number: 17760 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 17 Aug 2021 17:20:58 +0000 Gerrit-HasComments: Yes
