Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17771 )
Change subject: WiP: IMPALA-10798 : Prototype for JSON reader ...................................................................... Patch Set 1: (38 comments) http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h File be/src/exec/hdfs-json-scanner.h: http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@53 PS1, Line 53: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@74 PS1, Line 74: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@131 PS1, Line 131: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@134 PS1, Line 134: inline Status AllocateTupleMem(RowBatch* row_batch) WARN_UNUSED_RESULT; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@136 PS1, Line 136: int num_rows; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@137 PS1, Line 137: uint8_t* tuple_mem_end_ = nullptr; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@138 PS1, Line 138: const io::ScanRange* metadata_range_ = nullptr; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@139 PS1, Line 139: const char *filename() const { return metadata_range_->file(); } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.h@144 PS1, Line 144: boost::scoped_ptr<MemPool> data_batch_pool_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc File be/src/exec/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@38 PS1, Line 38: RETURN_IF_ERROR(scan_node->AddDiskIoRanges(file, EnqueueLocation::TAIL)); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@60 PS1, Line 60: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@66 PS1, Line 66: chunk_sizes_[*out] = size; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@71 PS1, Line 71: arrow::Status HdfsJsonScanner::ArrowMemPool::Reallocate(int64_t old_size, int64_t new_size, uint8_t** ptr) { line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@80 PS1, Line 80: << GetStackTrace(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@90 PS1, Line 90: arrow::Result<int64_t> HdfsJsonScanner::ScanRangeInputStream::Read(int64_t nbytes, void* out){ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@93 PS1, Line 93: int64_t fl = file_desc_->file_length; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@95 PS1, Line 95: nbytes = fl - pos_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@126 PS1, Line 126: arrow::Result<std::shared_ptr<arrow::Buffer>> HdfsJsonScanner::ScanRangeInputStream::Read(int64_t nbytes){ line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@180 PS1, Line 180: arrow::Status HdfsJsonScanner::ReadTable(std::shared_ptr<arrow::io::InputStream> input_stream){ line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@182 PS1, Line 182: ARROW_ASSIGN_OR_RAISE(reader_, arrow::json::TableReader::Make(arrow::default_memory_pool(), line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@191 PS1, Line 191: RETURN_IF_ERROR(HdfsScanner::Open(context)); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@197 PS1, Line 197: vector<std::shared_ptr<arrow::Field>> fields_list = {}; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@200 PS1, Line 200: std::shared_ptr<arrow::Field> field_a = arrow::field(cvf.name(), convert_type(cvf.type())); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@206 PS1, Line 206: readOptions_ = arrow::json::ReadOptions::Defaults(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@213 PS1, Line 213: VLOG_QUERY << "args: " << table_->ToString() << std::endl << GetStackTrace(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@232 PS1, Line 232: eos_ = true; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@241 PS1, Line 241: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@244 PS1, Line 244: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@246 PS1, Line 246: // reading rows from the previous point we left, tilll either end of table/capacity of rowbatch line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@254 PS1, Line 254: void* slot_val_ptr = tuple->GetSlot(slot_desc->tuple_offset()); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@255 PS1, Line 255: // helpful debug statements line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@283 PS1, Line 283: int dst_len = slot_desc->type().len; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@292 PS1, Line 292: src_ptr = blob_ + (val - blob->data()); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@305 PS1, Line 305: StringValue* dst = reinterpret_cast<StringValue*>(slot_val_ptr); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@309 PS1, Line 309: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@328 PS1, Line 328: Status s = CommitRows(row_read, row_batch); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/be/src/exec/hdfs-json-scanner.cc@337 PS1, Line 337: row_batch->tuple_data_pool()->AcquireData(data_batch_pool_.get(), false); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/17771/1/bin/bootstrap_toolchain.py@443 PS1, Line 443: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/17771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79364a421d862d0d837f9be694911e388d4d629 Gerrit-Change-Number: 17771 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 13 Aug 2021 23:24:24 +0000 Gerrit-HasComments: Yes
