Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17771 )
Change subject: WiP: IMPALA-10798 : Prototype for JSON reader ...................................................................... Patch Set 4: (38 comments) http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h File be/src/exec/hdfs-json-scanner.h: http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@70 PS4, Line 70: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@91 PS4, Line 91: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@148 PS4, Line 148: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@151 PS4, Line 151: inline Status AllocateTupleMem(RowBatch* row_batch) WARN_UNUSED_RESULT; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@153 PS4, Line 153: int num_rows; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@154 PS4, Line 154: uint8_t* tuple_mem_end_ = nullptr; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@155 PS4, Line 155: const io::ScanRange* metadata_range_ = nullptr; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@156 PS4, Line 156: const char *filename() const { return metadata_range_->file(); } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.h@161 PS4, Line 161: boost::scoped_ptr<MemPool> data_batch_pool_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc File be/src/exec/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@55 PS4, Line 55: RETURN_IF_ERROR(scan_node->AddDiskIoRanges(file, EnqueueLocation::TAIL)); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@77 PS4, Line 77: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@83 PS4, Line 83: chunk_sizes_[*out] = size; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@88 PS4, Line 88: arrow::Status HdfsJsonScanner::ArrowMemPool::Reallocate(int64_t old_size, int64_t new_size, uint8_t** ptr) { line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@97 PS4, Line 97: << GetStackTrace(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@107 PS4, Line 107: arrow::Result<int64_t> HdfsJsonScanner::ScanRangeInputStream::Read(int64_t nbytes, void* out){ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@110 PS4, Line 110: int64_t fl = file_desc_->file_length; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@112 PS4, Line 112: nbytes = fl - pos_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@143 PS4, Line 143: arrow::Result<std::shared_ptr<arrow::Buffer>> HdfsJsonScanner::ScanRangeInputStream::Read(int64_t nbytes){ line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@197 PS4, Line 197: arrow::Status HdfsJsonScanner::ReadTable(std::shared_ptr<arrow::io::InputStream> input_stream){ line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@199 PS4, Line 199: ARROW_ASSIGN_OR_RAISE(reader_, arrow::json::TableReader::Make(arrow::default_memory_pool(), line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@208 PS4, Line 208: RETURN_IF_ERROR(HdfsScanner::Open(context)); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@214 PS4, Line 214: vector<std::shared_ptr<arrow::Field>> fields_list = {}; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@217 PS4, Line 217: std::shared_ptr<arrow::Field> field_a = arrow::field(cvf.name(), convert_type(cvf.type())); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@223 PS4, Line 223: readOptions_ = arrow::json::ReadOptions::Defaults(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@230 PS4, Line 230: VLOG_QUERY << "args: " << table_->ToString() << std::endl << GetStackTrace(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@252 PS4, Line 252: eos_ = true; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@261 PS4, Line 261: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@264 PS4, Line 264: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@266 PS4, Line 266: // reading rows from the previous point we left, tilll either end of table/capacity of rowbatch line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@274 PS4, Line 274: void* slot_val_ptr = tuple->GetSlot(slot_desc->tuple_offset()); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@275 PS4, Line 275: // helpful debug statements line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@303 PS4, Line 303: int dst_len = slot_desc->type().len; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@312 PS4, Line 312: src_ptr = blob_ + (val - blob->data()); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@325 PS4, Line 325: StringValue* dst = reinterpret_cast<StringValue*>(slot_val_ptr); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@329 PS4, Line 329: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@348 PS4, Line 348: Status s = CommitRows(row_read, row_batch); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/be/src/exec/hdfs-json-scanner.cc@357 PS4, Line 357: row_batch->tuple_data_pool()->AcquireData(data_batch_pool_.get(), false); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/4/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/17771/4/bin/bootstrap_toolchain.py@443 PS4, Line 443: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/17771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79364a421d862d0d837f9be694911e388d4d629 Gerrit-Change-Number: 17771 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 14 Aug 2021 01:49:12 +0000 Gerrit-HasComments: Yes
