Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17771 )
Change subject: WiP: IMPALA-10798 : Prototype for JSON reader ...................................................................... Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.h File be/src/exec/hdfs-json-scanner.h: http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.h@70 PS5, Line 70: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.h@91 PS5, Line 91: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.h@153 PS5, Line 153: uint8_t* tuple_mem_end_ = nullptr; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.cc File be/src/exec/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.cc@55 PS5, Line 55: RETURN_IF_ERROR(scan_node->AddDiskIoRanges(file, EnqueueLocation::TAIL)); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.cc@98 PS5, Line 98: << GetStackTrace(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.cc@145 PS5, Line 145: arrow::Result<std::shared_ptr<arrow::Buffer>> line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.cc@203 PS5, Line 203: ARROW_ASSIGN_OR_RAISE(reader_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.cc@219 PS5, Line 219: vector<std::shared_ptr<arrow::Field>> fields_list = {}; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.cc@222 PS5, Line 222: std::shared_ptr<arrow::Field> field_a = arrow::field(cvf.name(), convert_type(cvf.type())); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17771/5/be/src/exec/hdfs-json-scanner.cc@271 PS5, Line 271: // reading rows from the previous point we left, tilll either end of table/capacity of rowbatch line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17771/5/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/17771/5/bin/bootstrap_toolchain.py@443 PS5, Line 443: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/17771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79364a421d862d0d837f9be694911e388d4d629 Gerrit-Change-Number: 17771 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 14 Aug 2021 02:33:19 +0000 Gerrit-HasComments: Yes
