Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 )
Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17765/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17765/1//COMMIT_MSG@9 PS1, Line 9: This patch adds support "FOR SYSTEM_TIME AS OF" and Please clarify the the timestamp specified with "FOR SYSTEM_TIME AS OF" is interpreted to be in the local timezone. Local timezone meaning the coordinator node's local timezone. http://gerrit.cloudera.org:8080/#/c/17765/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/17765/1/tests/query_test/test_iceberg.py@197 PS1, Line 197: # Query old snapshot > Maybe add another test to query with a timestamp in the future. You could also test (if not too much work) that switching Impala to another timezone (e.g. using TIMEZONE query option) changes the results of the time travel query. -- To view, visit http://gerrit.cloudera.org:8080/17765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib523c5e47b8d9c377bea39a82fe20249177cf824 Gerrit-Change-Number: 17765 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 25 Aug 2021 11:58:09 +0000 Gerrit-HasComments: Yes
