Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 )
Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17765/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/17765/1/tests/query_test/test_iceberg.py@197 PS1, Line 197: # Query old snapshot > We are using the local timezone of the machine that executes the test. I do What I was thinking of is to set TIMEZONE query option to a specific timezone for the queries and get the current timestamp after each query with "select now();" (with TIMEZONE set to the same timezone). This way we wouldn't depend on the local timezone of the machine. A test could compare the results for the same timestamp in different TIMEZONEs, to prove that time travel uses the coordinator's local timezone. Anyway, it was just a silly idea. Now that I think about it, it doesn't sound too useful. Feel free to ignore it. http://gerrit.cloudera.org:8080/#/c/17765/1/tests/query_test/test_iceberg.py@197 PS1, Line 197: # Query old snapshot > Currently querying the future behaves the same as querying by now(). I'm no Sure, use your best judgement. -- To view, visit http://gerrit.cloudera.org:8080/17765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib523c5e47b8d9c377bea39a82fe20249177cf824 Gerrit-Change-Number: 17765 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 26 Aug 2021 15:08:45 +0000 Gerrit-HasComments: Yes
