Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17794 )

Change subject: IMPALA-10822: Allow multiple group returns for LDAP Search
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17794/4/be/src/util/ldap-util.cc
File be/src/util/ldap-util.cc:

http://gerrit.cloudera.org:8080/#/c/17794/4/be/src/util/ldap-util.cc@a204
PS4, Line 204:
             :
> Just to clarify, you mean >0? Because this commit tries to unblock
 > the >=1 scenario for group searches.
I mean returning in the < 1 case - this would mean 0 matches or error in case 
of -1.



--
To view, visit http://gerrit.cloudera.org:8080/17794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I27eaf717985207e36d4fa47a2af757d06544474e
Gerrit-Change-Number: 17794
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>
Gerrit-Comment-Date: Wed, 25 Aug 2021 14:37:47 +0000
Gerrit-HasComments: Yes

Reply via email to