Tamas Mate has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/17794 )
Change subject: IMPALA-10822: Allow multiple group returns for LDAP Search ...................................................................... IMPALA-10822: Allow multiple group returns for LDAP Search This commit updates the LdapSearch method to allow multiple results by refactoring the condition that checks the number of results. The condition was removed from the method and it is now the caller's responsibility to decide if the returned number of results are correct. The change was necessary, because the LdapSearch method was written too generally and used for both user and group searches. While it is reasonable to fail authentication requests where the LDAP Search returns more than one user this should not be the case for group searches, as a user can be part of multiple groups matching the search criteria. Testing: - Updated the unit test to cover this use-case Change-Id: I27eaf717985207e36d4fa47a2af757d06544474e --- M be/src/util/ldap-search-bind.cc M be/src/util/ldap-simple-bind.cc M be/src/util/ldap-util.cc M be/src/util/ldap-util.h M fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java M fe/src/test/resources/users.ldif 6 files changed, 60 insertions(+), 35 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/17794/6 -- To view, visit http://gerrit.cloudera.org:8080/17794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I27eaf717985207e36d4fa47a2af757d06544474e Gerrit-Change-Number: 17794 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]>
