Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15403 )

Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner
......................................................................


Patch Set 6:

> It will also be great if we can add a test to show push-down predicates in 
> the ORC scan node in a query plan.

We have such a case in orc-stats.test

 ====
 ---- QUERY
 set explain_level=2;
 explain select id, bool_col from functional_orc_def.alltypessmall where 
int_col < 0;
 ---- RESULTS: VERIFY_IS_SUBSET
 '   orc statistics predicates: int_col < CAST(0 AS INT)'
 ====

But I think we do need to improve observability on the final predicates that 
are pushed down. E.g. "x = 1" is currently transformed into "x <= 1" and "x >= 
1" but it's not shown in the plan.


--
To view, visit http://gerrit.cloudera.org:8080/15403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I136622413db21e0941d238ab6aeea901a6464845
Gerrit-Change-Number: 15403
Gerrit-PatchSet: 6
Gerrit-Owner: Norbert Luksa <[email protected]>
Gerrit-Reviewer: Anonymous Coward (520)
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Norbert Luksa <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 26 Aug 2021 04:04:53 +0000
Gerrit-HasComments: No

Reply via email to