Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 )
Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15403/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/15403/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@428 PS7, Line 428: computeMinMaxTupleAndConjuncts(analyzer) As a followup question about showing ORC stats predicates vs. ORC push-down predicates. It seems that we could remove those push-down predicates from conjuncts_ since there is no point to evaluate them again. This also calls for a tight control over the generation of ORC push-down predicates: if FE decides some predicate p is pushable, then BE should raise an error if p is not so in practice. -- To view, visit http://gerrit.cloudera.org:8080/15403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136622413db21e0941d238ab6aeea901a6464845 Gerrit-Change-Number: 15403 Gerrit-PatchSet: 7 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Anonymous Coward (520) Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 26 Aug 2021 20:54:02 +0000 Gerrit-HasComments: Yes
