Qifan Chen has posted comments on this change. (
http://gerrit.cloudera.org:8080/17780 )
Change subject: IMPALA-9662,IMPALA-2019(part-3): Support UTF-8 mode in mask
functions
......................................................................
Patch Set 4:
My understanding is that the following function will be used to return the
masted character for the ASCII upper case or lower case. The concern is whether
it should be enhanced to deal with Unicode upper case or lower case characters.
For example, 00c0 is the latin upper case letter of A with grave.
static inline uint32_t MaskTransform(uint32_t val, int masked_upper_char,
int masked_lower_char, int masked_digit_char, int masked_other_char) {
if ('A' <= val && val <= 'Z') {
if (masked_upper_char == UNMASKED_VAL) return val;
return masked_upper_char;
}
if ('a' <= val && val <= 'z') {
if (masked_lower_char == UNMASKED_VAL) return val;
return masked_lower_char;
}
if ('0' <= val && val <= '9') {
if (masked_digit_char == UNMASKED_VAL) return val;
return masked_digit_char;
}
if (masked_other_char == UNMASKED_VAL) return val;
return masked_other_char;
}
--
To view, visit http://gerrit.cloudera.org:8080/17780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1276eccc94c9528507349b155a51e76f338367d5
Gerrit-Change-Number: 17780
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 07 Sep 2021 14:54:29 +0000
Gerrit-HasComments: No
