Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17819 )
Change subject: IMPALA-10883: Do not override existing counters with empty profile ...................................................................... Patch Set 2: (2 comments) Thanks Quanlong! I address your comments in patch set 2. http://gerrit.cloudera.org:8080/#/c/17819/1/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/17819/1/be/src/util/runtime-profile-test.cc@1489 PS1, Line 1489: (i - offset + 1) * 11 > This should be 10 when i == offset due to line 1566. Or should we set the c Thanks for catching this! I fix line 1566 to set the counter value to 11. http://gerrit.cloudera.org:8080/#/c/17819/1/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/17819/1/be/src/util/runtime-profile.cc@627 PS1, Line 627: int idx = start_idx + i; > I traced the codes generating 'values' but still not sure whether a valid ' Done -- To view, visit http://gerrit.cloudera.org:8080/17819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bb179bf739ffaa4e5ec8dc911480ac835ae387f Gerrit-Change-Number: 17819 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 07 Sep 2021 15:38:45 +0000 Gerrit-HasComments: Yes
