Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17819 )
Change subject: IMPALA-10883: Do not override existing counters with empty profile ...................................................................... IMPALA-10883: Do not override existing counters with empty profile Some profile information was missing when gen_experimental_profile flag is enabled. This is because profile aggregation in the coordinator does not anticipate a partial update from a backend. From a backend perspective, if a fragment instance has sent its final report, that instance will not participate in the subsequent profile report. Therefore, the aggregated counters that belong to the finished instance will be empty. This patch adds empty checks in the aggregation of input_profile_names_, TAggTimeSeriesCounter, and TAggEventSequence to prevent the existing value from being overridden by an empty profile. Testing: - Add BE test CountersTest.PartialUpdate Change-Id: I9bb179bf739ffaa4e5ec8dc911480ac835ae387f Reviewed-on: http://gerrit.cloudera.org:8080/17819 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/runtime-profile-test.cc M be/src/util/runtime-profile.cc 2 files changed, 139 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9bb179bf739ffaa4e5ec8dc911480ac835ae387f Gerrit-Change-Number: 17819 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
