Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 )
Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever ...................................................................... Patch Set 25: (1 comment) http://gerrit.cloudera.org:8080/#/c/17872/21/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17872/21/be/src/service/client-request-state.cc@713 PS21, Line 713: // If this is a CTAS request, there will usually be more work to do : // after executing the CREATE TABLE statement (the INSERT portion of the operation). : // The exception is if the user specified IF NOT EXISTS and the table already : // existed, in which case we do not execute the INSERT. : if (catalog_op_type() == TCatalogOpType::DDL && : > Yes, the code to enter into the PENDING state is removed. I should have been more explicit. I want CTAS to go to PENDING and non-CTAS to go to RUNNING. I want the state transition to happen in ExecDdlRequest() in the ShouldRunExecDdlAsync()==true case prior to spawning the async thread. I want them to be right next to each other so that the distinction is very clear: // Comment about why CTAS goes to PENDING rather than running. if (ctas) UpdateNonErrorExecState(ExecState::PENDING); else UpdateNonErrorExecState(ExecState::RUNNING); RETURN_IF_ERROR(Thread::Create(...)) -- To view, visit http://gerrit.cloudera.org:8080/17872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e Gerrit-Change-Number: 17872 Gerrit-PatchSet: 25 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Wed, 13 Oct 2021 22:05:20 +0000 Gerrit-HasComments: Yes
