Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 )
Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever ...................................................................... Patch Set 25: (1 comment) http://gerrit.cloudera.org:8080/#/c/17872/21/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17872/21/be/src/service/client-request-state.cc@713 PS21, Line 713: // If this is a CTAS request, there will usually be more work to do : // after executing the CREATE TABLE statement (the INSERT portion of the operation). : // The exception is if the user specified IF NOT EXISTS and the table already : // existed, in which case we do not execute the INSERT. : if (catalog_op_type() == TCatalogOpType::DDL && : > I should have been more explicit. I want CTAS to go to PENDING and non-CTAS I do not think it will work, since Exec() sets the state to RUNNING (at the end of the method) for sync code path, and RUNNING->RUNNING is not allowed. So what we should do is to set the state for async only, which is exactly done here, to avoid another illegal transition INITIALIZED->FINISHED I can add a comment in ExecDdlRequest() to explain this. -- To view, visit http://gerrit.cloudera.org:8080/17872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e Gerrit-Change-Number: 17872 Gerrit-PatchSet: 25 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Wed, 13 Oct 2021 23:26:33 +0000 Gerrit-HasComments: Yes
